/[qemu]
ViewVC logotype

Revision 4956


Jump to revision: Previous Next
Author: aliguori
Date: Mon Jul 28 18:55:32 2008 UTC (15 years, 3 months ago)
Changed paths: 1
Log Message:
Attempt to detect unconnected ptys (Gerd Hoffman)

This patch moves the pty char device imlementation away from the generic
filehandle code.  It tries to detect as good as possible whenever there
is someone connected to the slave pty device and only send data down the
road in case someone is listening.  Unfortunaly we have to poll via
timer once in a while to check the status because we have to use read()
on the master pty to figure the status (returns -EIO when unconnected).

Poll intervall for an idle guest is one second, when the guest sends
data to the virtual device linked to the pty we check more frequently.

The point for all of this is to avoid qemu blocking and not responding
any more.  Writing to the master pty handle succeeds even when nobody is
connected to (and reading from) to the slave end of the pty.  The kernel
just bufferes the writes.  And as soon as the kernel buffer is full the
write() call blocks forever ...

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>


Changed paths:

Path Details
Directorytrunk/vl.c modified , text changed

savannah-hackers-public@gnu.org
ViewVC Help
Powered by ViewVC 1.1.5